{{ message }}
Repository navigation
Read Snowflake result partitions using the SQL API contract - #1062
Merged
WaylandYang merged 2 commits intoOct 3, 2026
Merged
Conversation
…ete queries Signed-off-by: dada-yan <BinjunYann@gmail.com>
WaylandYang
approved these changes
Oct 3, 2026
WaylandYang
left a comment
WaylandYang
left a comment
Contributor
There was a problem hiding this comment.
Thanks @Maya-Kid. This matches the SQL API: partitionInfo carries row counts and sizes, not URLs, and later partitions are read by statement handle with ?partition=N, without metadata, so the first response's column types are reused. The earlier fixture modelled a field the API does not have. Not verified against a live account, as you say; #242 stays open for that. Landing it.
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Snowflake SQL API partition metadata contains row counts and sizes, not URLs. Any real multi-partition query therefore failed with
partition without a url, including schema ingestion. The previous fixture inadvertently modeled the same nonexistent field.Fetch subsequent partitions using the statement handle and
?partition=N, starting at 1 because partition 0 is returned inline. Reuse the initial column types for metadata-free partition responses and keep the existing completeness checks. Correct the fixtures to match the official response contract, including gzip compression.The corrected schema regression failed before the fix. Tests also cover asynchronous execution, typed/null rows across partitions, authentication, missing handles, HTTP errors, and missing rows.
Validation: format check, workspace clippy with warnings denied, guarded workspace tests with dedicated PostgreSQL 16/pgvector and PDF extraction required, and workspace build passed. Frozen pnpm 10.2.1 install, 228 frontend tests, and production build also passed. Cloud behavior is validated against documented HTTP fixtures; no live Snowflake account was used.