fix: no-ticket: use relative node-version-file path for setup-node v7.1.0 by mofojed · Pull Request #8948 · deephaven/deephaven-core · GitHub
Skip to content

fix: no-ticket: use relative node-version-file path for setup-node v7.1.0 - #8948

Merged
mofojed merged 1 commit into
deephaven:mainfrom
mofojed:fix-update-web-action
Oct 19, 2026
Merged

mofojed merged 1 commit into
deephaven:mainfrom
mofojed:fix-update-web-action

Conversation

@mofojed

@mofojed mofojed commented Oct 19, 2026

Copy link
Copy Markdown
Member

The "Update web version" workflow started failing with:

Error: The specified node version file at: /web/client-api/types/.nvmrc does not exist

The failure began after Dependabot bumped actions/setup-node from v7.0.0
to v7.1.0 (7212db0). v7.1.0 added "Support absolute paths in
node-version-file" (actions/setup-node#1633). Previously the input was
always joined onto $GITHUB_WORKSPACE, so the leading "/" was harmless.
Now a path starting with "/" is treated as absolute on the runner
filesystem, so the action looked outside the checkout.

Drop the leading slash so the path resolves relative to the workspace.
The leading slashes under sparse-checkout are git patterns anchored at
the repo root and are unaffected.

Release notes: https://github.com/actions/setup-node/releases/tag/v7.1.0

….1.0

The "Update web version" workflow started failing with:

  Error: The specified node version file at: /web/client-api/types/.nvmrc does not exist

The failure began after Dependabot bumped actions/setup-node from v7.0.0
to v7.1.0 (7212db0). v7.1.0 added "Support absolute paths in
node-version-file" (actions/setup-node#1633). Previously the input was
always joined onto $GITHUB_WORKSPACE, so the leading "/" was harmless.
Now a path starting with "/" is treated as absolute on the runner
filesystem, so the action looked outside the checkout.

Drop the leading slash so the path resolves relative to the workspace.
The leading slashes under sparse-checkout are git patterns anchored at
the repo root and are unaffected.

Release notes: https://github.com/actions/setup-node/releases/tag/v7.1.0
Copilot AI balanced review requested due to automatic review settings October 19, 2026 14:53
@semanticdiff-com

semanticdiff-com Bot commented Oct 19, 2026 •

Copy link
Copy Markdown

@github-actions

Copy link
Copy Markdown
Contributor

No docs changes detected for ed6f6c4

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟢 Approval recommended

The relative path matches the checked-out file and setup-node’s path resolution behavior.

No open issues 🎉

What changed in this PR

Fixes Node setup in the “Update web version” workflow after the setup-node v7.1.0 upgrade.

Changes:

  • Makes node-version-file relative to the workspace.
  • Leaves sparse-checkout patterns unchanged.
File Description
.github/​workflows/​update-web.yml Removes the leading slash from the .nvmrc path.

Review effort: Balanced

@mofojed
mofojed enabled auto-merge (squash) October 19, 2026 14:57
@mofojed
mofojed merged commit 7a1430b into deephaven:main Oct 19, 2026
29 of 31 checks passed
@mofojed
mofojed deleted the fix-update-web-action branch October 19, 2026 15:54
@github-actions github-actions Bot locked and limited conversation to collaborators Oct 19, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants