New: Typescript 4.7+ compatibility by vibhurajeev · Pull Request #114 · dcodeIO/long.js · GitHub
Skip to content

New: Typescript 4.7+ compatibility#114

Closed
vibhurajeev wants to merge 1 commit into
dcodeIO:mainfrom
vibhurajeev:vibhu-ts-4.7-compatibility
Closed

New: Typescript 4.7+ compatibility#114
vibhurajeev wants to merge 1 commit into
dcodeIO:mainfrom
vibhurajeev:vibhu-ts-4.7-compatibility

Conversation

@vibhurajeev

Copy link
Copy Markdown

Typescript 4.7^ with mode resolution strategy set to nodenext, is confused about finding export = in d.ts file and complains about default import not being allowed (when imported as import Long from "long") as the heuristics used by typescript to guess seems to be inaccurate. Having export default would help fix this.

@zakarialounes

Copy link
Copy Markdown

@reyawn

reyawn commented Feb 13, 2023

Copy link
Copy Markdown

Seems that this was removed as per 45f1f37 to fix issues with UMD, but the "fix" broke other things.

@dcodeIO

dcodeIO commented Apr 16, 2023

Copy link
Copy Markdown
Owner

@dcodeIO dcodeIO closed this Apr 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants