{{ message }}
Add collation completions and more charset completions#1711
Merged
rolandwalker merged 1 commit intomainfrom Mar 16, 2026
Merged
Add collation completions and more charset completions#1711rolandwalker merged 1 commit intomainfrom
rolandwalker merged 1 commit intomainfrom
Conversation
rolandwalker
force-pushed
the
RW/collation-and-charset-completion-improvements
branch
from
256d614 to
1001ed8
Compare
rolandwalker
force-pushed
the
RW/collation-and-charset-completion-improvements
branch
from
1001ed8 to
ab90743
Compare
scottnemes
approved these changes
Mar 16, 2026
Complete in these positions:
* "string" COLLATE ^
* CONVERT("string" USING ^
* CAST("string" as CHAR CHARACTER SET ^
Refactor stored charsets to not be per-schema, which was not necessary.
Add commentary on the pre-existing issue of the WHERE logic short-
circuiting other useful completions, and some other edge cases such
as overenthusiastic blocking of numeric completions.
rolandwalker
force-pushed
the
RW/collation-and-charset-completion-improvements
branch
from
ab90743 to
63507be
Compare
rolandwalker
deleted the
RW/collation-and-charset-completion-improvements
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Complete in these positions:
"string" COLLATE ^CONVERT("string" USING ^CAST("string" as CHAR CHARACTER SET ^Refactor stored charsets to not be per-schema, which was not necessary.
Add commentary on the pre-existing issue of the
WHERElogic short- circuiting other useful completions, and some other edge cases such as overenthusiastic blocking of numeric completions.Examples:
Checklist
changelog.mdfile.AUTHORSfile (or it's already there).