Update to latest practices in packaging.#8
Conversation
Python3(print_func)and other python best practices.
updated the shebang line
changed the version
docstring ,encoding ,seper!ted module and built in imports
removed typo and changed a bit of vocab
Disutils
Had forgotten the shebang
Added repl
|
Let me know when it's ready for another look. Looked like there were some typos and testing changes in there still. Were you able to confirm the basic setup.py commands work using distutils? |
|
Yah I will let you know |
minor changes
This pull request configures this repository to be run on Repl.it. It adds a `.replit` configuration file and a Repl.it badge to the `README`.
You can read more about running repos on Repl.it [here](https://docs.repl.it/repls/dot-replit), or view the Repl [here](https://repl.it/@TEENBOOM/python-helloworld-1).
Add run on repl.it badge to README
|
i think i have removed all typos? |
|
let me know if you find some, please. |
|
disutils.py doesn't have dependency_links, install_requires, extras_require & entry_points. |
|
disutils doesn't work |
switched to setuptools and added long description
added LICENSE
LICENSE ADDED
added badge
dbarnett
left a comment
dbarnett
left a comment
There was a problem hiding this comment.
Some of these were older "Pending" comments I apparently forgot to send. Sorry for the drawn-out review.
Removed typos, shebang line
|
It's done |
|
You may verify the changes |
|
Can you pull and rebase from the master branch, after commit 66a0101 and #11? I might be misreading the diff, but it looks like you have some changes to the same files that will conflict. Apologies for the merge conflicts. A lot of files changed in this PR to conflict. BTW, I'll tend to get to smaller single-purpose PRs much quicker just because GitHub makes little uncontroversial PRs easy to quickly approve and merge (from my phone even). For more involved reviews I have to find time to break out the laptop and do a bunch of commenting. Either way, thanks for contributing! |
|
I will do it but I have exams rn, so I am taking some time off of coding.might take 1 month. |
|
Actually it's not that big I will see if I can do it in middle of the exams. |
|
BTW the license is not valid |
|
i will start an issue for that. |
added single line code block and removed <br>
url corrected
|
Changes look good to me. Consider changing the PR title since it's no longer about python 3.x, and either way I'll merge it later today. |
|
Two question. I am using substantial amount of code (some of it is not modified)from this repo, so do I need to attach your copyright? 2.why are there two version.txt files? |
2 participants
Changes
updated README with slight change of vocabulary
took inspiration from the open pull requests
changed the version to 0.2
added docstrings no specific format was followed for them.
Changes that should be considered