{{ message }}
Repository navigation
deps: use plotly.rs 0.15.0 release branch; regenerate viz gallery - #4836
Merged
Merged
Conversation
…enerate viz gallery Point the plotly [patch] at the 0.15.0 release-prep PR head (dathere/plotly@a21da1f) and bump the plotly requirement to 0.15 so the patch applies. This pulls in plotly_derive 0.15.0 and plotly_static 0.2.0, and drops darling 0.23 and lzma-rust2 (via plotly's removed zip build-dependency). qsv does not use the removed Kaleido backend or ImageFormat::EPS. The embedded plotly.js bundle is unchanged (3.7.0). Regenerated the viz gallery with gen_gallery.py: gallery.html is byte-identical; 14 smart dashboards pick up the 25.0.0 compile stamp, and two map pages (smart_us_choropleth, smart_world_events) get richer hover place names from the 25.0.0 geocode index. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Starts using plotly.rs 0.15.0 before it's released, by pointing the
plotly[patch.crates-io]at the head of the release-prep PR plotly/plotly.rs#442 (dathere/plotly@a21da1f).Cargo.toml: theplotlyrequirement goes from0.14.1to0.15, because a^0.14.1requirement won't accept a 0.15.0 patch. The patch now points at the PR head byrev.Cargo.lock:plotly0.15.0,plotly_derive0.15.0 andplotly_static0.2.0. This dropsdarling0.23 andlzma-rust2(plotly removed its unusedzipbuild-dependency) and movesdirsfrom 6 to 7.ImageFormat::EPSthat 0.15.0 removes.plotly_cdn_sri_matches_the_embedded_bundlepasses.Gallery regenerated (
examples/viz/gen_gallery.py)gallery.htmlis byte-identical.smart_*.htmldashboards get the current compile stamp andGenerated by: qsv 25.0.0(they were built with 24.0.0).smart_us_choropleth.htmlandsmart_world_events.htmlget more detailed hover place names from the 25.0.0 geocode index, e.g. Connecticut planning regions. This comes from the index, not from plotly.QSV_VIZ_REGEN_LLM).cargo publishignores[patch], so qsv can't be published to crates.io untilplotly0.15.0 is out there. Once it is, drop the patch.Testing
cargo t viz -F all_features: 1,119 passed, 0 failed (482 unit, 637 integration).#[ignore]d browser and geocode tests, run with a ChromeDriver whose major version matches Chrome (155): 15 passed, 0 failed. That's the 11viz_static_*tests,viz_smart_image_export_does_not_report_the_discarded_choropleth, and the 3 Geonames-index tests, so static image export throughplotly_static0.2.0 works at runtime. The only test not run isviz_denominator_census_is_reserved, which is still skipped while the Census API is down.cargo clippy --bin qsv -F all_features: the only warning is atoo_many_argumentsone inviz.rsthat was already on master.🤖 Generated with Claude Code