[🍒][PLUGIN-1752] Changed parent class to ReferenceBatchSource by psainics · Pull Request #68 · data-integrations/multi-table-plugins · GitHub
Skip to content

[🍒][PLUGIN-1752] Changed parent class to ReferenceBatchSource#68

Merged
psainics merged 1 commit intodata-integrations:release/1.4from
cloudsufi:cherry-pick-f06b0df0a11da2eee54a5dc7ca60ff769113e79c
Oct 30, 2024
Merged

[🍒][PLUGIN-1752] Changed parent class to ReferenceBatchSource#68
psainics merged 1 commit intodata-integrations:release/1.4from
cloudsufi:cherry-pick-f06b0df0a11da2eee54a5dc7ca60ff769113e79c

Conversation

@psainics
Copy link
Copy Markdown

🍒 [cherrypick]

Commits :

PR:


MultiTableDBSource now extends MultiTableDBSource

Jira : Plugin-1752

Description

Earlier pipeline failed due to space / special characters in field Reference Name*
We now make MultiTableDBSource extend ReferenceBatchSource that include validations for the field!

image

Unit Tests

  • Added a unit test to verify space is not allowed in reference name.
image

@psainics psainics self-assigned this Oct 28, 2024
@psainics psainics merged commit 4fc6c71 into data-integrations:release/1.4 Oct 30, 2024
@psainics psainics deleted the cherry-pick-f06b0df0a11da2eee54a5dc7ca60ff769113e79c branch October 30, 2024 05:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants