Allow for multiple Team splits and team cloning by devreal · Pull Request #663 · dash-project/dash · GitHub
Skip to content

Allow for multiple Team splits and team cloning#663

Open
devreal wants to merge 3 commits into
developmentfrom
bug-658-teamsplit
Open

Allow for multiple Team splits and team cloning#663
devreal wants to merge 3 commits into
developmentfrom
bug-658-teamsplit

Conversation

@devreal

@devreal devreal commented Jul 19, 2019

Copy link
Copy Markdown
Member

Make the team hierarchy a tree and allow for cloning teams, which is useful in multi-threaded environments.

Fixes #658

@codecov

codecov Bot commented Jul 19, 2019

Copy link
Copy Markdown

@bertwesarg

Copy link
Copy Markdown
Member

As you disable all of the traversial API, than why do we have this _children member at all? I think most users can live without this member. AFAIK, MPI does not have a child concept at all for its communicators and windows.

@devreal

devreal commented Jul 19, 2019

Copy link
Copy Markdown
Member Author

Good question. It doesn't seem to be used anywhere in the examples or applications and I don't see an immediate use-case to iterate over levels in the Team tree. My guess is that since the localities are hierarchical the teams were meant to be as well but I'm not sure that that is useful...

@bertwesarg

Copy link
Copy Markdown
Member

There is one reason though, the deconstructor, which also removes all children. I'm fine with this as is.

Comment thread dash/include/dash/Team.h

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

mutable?

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It should be mutable once we have const Teams :D

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I only referenced the _mutex (see the M&M rule here). Also, I think that this and the _children would be a prerequisite for having const Teams in the future.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Cannot split a team multiple times

2 participants