{{ message }}
Allow specifying file:/// URIs inside Dev tools > Dynamic Theme Editor > Per Site Editor#14928
Open
SuperCowProducts wants to merge 1 commit intodarkreader:mainfrom
Open
Allow specifying file:/// URIs inside Dev tools > Dynamic Theme Editor > Per Site Editor#14928SuperCowProducts wants to merge 1 commit intodarkreader:mainfrom
file:/// URIs inside Dev tools > Dynamic Theme Editor > Per Site Editor#14928SuperCowProducts wants to merge 1 commit intodarkreader:mainfrom
Conversation
Added comment about TypeError related to button function.
Collaborator
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

TL;DR: I commented what I want to fix in the source which is causing this
Here is an example:
Dark mode for this site only works well with 'Static' mode, yet I want all other site to be in 'Dynamic' mode. Only way to do this seemed to be
Dev tools > Dynamic Theme Editor > Per Site Editor: actually you can get it done via GUI like this, but that's hacky and hard to come up with (that special menu started appearing once I had openedDev toolsin a new window).funnily enough, if in the same prompt we run
we can get around the
file://problem as well.The point is: if this is possible and could help some users, why don't we make the Dark Reader tool more flexible and allow
file://URIs (or potentially others if that would be even better), instead of being in my opinion overly restrictive?Not that I didn't get it to work in the end, this is mainly to help future users have to do less tinkering and access the feature more easily :)