Feat/ach pull#11
Conversation
There was a problem hiding this comment.
Move them to be after the getAccountsMetadata method.
There was a problem hiding this comment.
Both methods should have 2 versions, one that has the operationID and userInputs parameters, and one that doesn't.
There was a problem hiding this comment.
Also, in the case of getACHPull, the operationID has to be always passed, as it's a required field for the endpoint.
| return respBody ?? new GetACHPullResponse("UNEXPECTED_RESPONSE", "Unexpected response body"); | ||
| } | ||
|
|
||
| public class ACHPull { |
| this.senderID = transfer.senderID; | ||
| this.amount = transfer.amount; | ||
| this.description = transfer.description; |
There was a problem hiding this comment.
This will not work. These fields should be inside the transfer object field, not directly in the root.
| /// This is a private constructor to this lib. | ||
| /// </summary> | ||
| [JsonConstructor] | ||
| internal CreateACHPullResponse(APIStatus status, bool success, string operationID) : |
There was a problem hiding this comment.
This constructor is missing the userInputs, type and msg fields.
| @@ -0,0 +1,13 @@ | |||
| namespace Dapi.Types { | |||
| public class ACHGetTransfer { | |||
There was a problem hiding this comment.
Rename it to ACHPullTransferInfo.
There was a problem hiding this comment.
This constructor is missing the userInputs, type and msg fields.
3 participants
No description provided.