{{ message }}
Conversation
python/cpython#92537 removed the code from CPython, but left the public function as a no-op for back compatibility. Thus, even though the (private) machinery is gone, cython is still trying to use it. This changes the guard to look at the private function. closes cython#4788
Collaborator
Collaborator
|
I think the right way to do this is just a |
Contributor
|
I think the right way to do this is just a `PY_VERSION_HEX` check
rather than trying to detect is the macros/functions are there.
It might be a mix of both in the end. I'm looking into it.
|
Contributor
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
python/cpython#92537 removed the code from CPython, but left the
public function as a no-op for back compatibility. Thus, even though
the (private) machinery is gone, cython is still trying to use it.
This changes the guard to look at the private function.
closes #4788