{{ message }}
Repository navigation
allow compilation without git or when git fails - #300
Open
ursfassler wants to merge 1 commit into
Open
ursfassler wants to merge 1 commit into
ursfassler wants to merge 1 commit into
Conversation
This happens when the code is downloaded as source archive. This does not contain the git repository, hence the git version script fails. Now the version 0.0.0+YEAR.MONTH.DAY is used when we fail to get the version from git.
Contributor
Author
Contributor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Summary
Allow compilation without git or when git fails.
Details
This happens when the code is downloaded as source archive. This does not contain the git repository, hence the git version script fails.
Now the version 0.0.0+YEAR.MONTH.DAY is used when we fail to get the version from git.
Motivation and Context
One problem mentioned in #295.
How Has This Been Tested?
Manually by removing the .git directory and adding it back again.
Downloaded the zip archive and did a CMake configure.
Types of changes
Checklist: