{{ message }}
Repository navigation
Conversation
Switch the SearchPhase trait solutions to not take a mutable reference, and instead use a RefCell to get interior mutability for increasing the size of the prune table.
Member
Author
|
The code is entirely mine, but I did use an LLM to get better understanding of the repo before I implemented this ie. asking question about the code, but never asking it to write code. |
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Switch the
SearchPhasetrait solutions to not take a mutable reference, and instead use aRefCellto get interior mutability for increasing the size of the prune table.Also sets the
max_depth_exclusiveto 15 for the 4x4x4 phase3.From what I benchmarked, setting it to 14, as it was in the comment makes it take several times longer to solve. Increasing it to 15 fixes it.
This is basically a ~1% regression for scrambles that were finding a solution without backtracking, due to the introduction of the RefCell, but a improvement of 10-35% for the rest. The benchmark code I used is in
src/lib/bin/bench4x4x4.rs