{{ message }}
Repository navigation
Consolidate completion checks - #312
Open
iamshravanijadhav wants to merge 2 commits into
Open
iamshravanijadhav wants to merge 2 commits into
iamshravanijadhav wants to merge 2 commits into
Conversation
iamshravanijadhav
requested review from
TimidRobot and
possumbilities
and removed request for
a team
October 8, 2026 08:06
TimidRobot
requested changes
Oct 8, 2026
TimidRobot
left a comment
Member
There was a problem hiding this comment.
Great work, thank you!
This work stands on it's own, but it would benefit from updating the fetch scripts, as well.
Comment on lines
+52
to
+53
Member
There was a problem hiding this comment.
Please expand this a little more to explain expected data structure of files and that minimum_lines can be 0 or None to skip that check.
Contributor
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Fixes
Description
This PR moves the completion check used by the process and report scripts into one shared function.
I replaced
check_completion_file_existswithcheck_for_completion(args, files)inscripts/shared.pyand updated the 8 scripts that were using the old function.The shared check now also supports
--enable-saveand--force.Technical details
The new function takes a dictionary in the form
{file_path: minimum_lines}and checks whether the expected output files are present and complete.For the current process and report scripts, the minimum line count is not required, so the files are passed with
None.Tests
python -m py_compileon the modified files.git diff --check.--forceskips the completion check.python -m unittest discover(0 tests found).Checklist
Update index.md).mainormaster).visible errors.
Developer Certificate of Origin
For the purposes of this DCO, "license" is equivalent to "license or public domain dedication," and "open source license" is equivalent to "open content license or public domain dedication."
Developer Certificate of Origin