{{ message }}
Rename changelog.rst to CHANGELOG.rst#278
Merged
Merged
Conversation
aaronliu0130
requested changes
Jul 7, 2024
aaronliu0130
left a comment
aaronliu0130
left a comment
Member
There was a problem hiding this comment.
I was thinking about this a while ago and would actually prefer the opposite: renaming changelog.rst to CHANGELOG.rst so it's consistent with other documentation.
Contributor
Author
Member
|
Thanks, but it'd be easier for all of us here if you committed the changes to your own branch, since we have mandatory review here yet all the other maintainers are inactive while I do not have the power to add other maintainers. |
For consistency with other .rst files in the root. This also fixes some documentation that previously referred to the uppercased name.
ember91
changed the title
Contributor
Author
aaronliu0130
approved these changes
Aug 2, 2024
aaronliu0130
left a comment
aaronliu0130
left a comment
Member
There was a problem hiding this comment.
Sorry for the long delay, I had some academci commitments. LGTM!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Apparently it was renamed, breaking some documentation in the process.