{{ message }}
Fix #680: Add option to keep comments in preprocessed code - #681
Merged
ludviggunne merged 3 commits intoJul 24, 2026
Merged
Conversation
danmar
reviewed
Jul 13, 2026
danmar
left a comment
danmar
left a comment
Collaborator
There was a problem hiding this comment.
I don't see the use case to treat comments differently in the source file and in included files. do you know the reason?
Collaborator
ludviggunne
force-pushed
the
keep-comments
branch
from
July 13, 2026 12:12
41d16e9 to
04b4e45
Compare
danmar
approved these changes
Jul 13, 2026
Collaborator
There was a problem hiding this comment.
this may be questionable. do we want that comments are expanded. maybe the comment should only be kept on line 1.
but for now .. as far as I see it does not matter much. If somebody has strong opinions later and wants to change I am not against changing..
Collaborator
Author
There was a problem hiding this comment.
gcc does copy comments in expansions. it will however turn c++-style comments in to c-style comments: https://gcc.gnu.org/onlinedocs/gcc/Preprocessor-Options.html
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.