{{ message }}
Fix #677: Exception in async_server_base/async_connection during port scanning (nmap)#678
Closed
vovams wants to merge 1 commit intocpp-netlib:0.12-releasefrom
Closed
Fix #677: Exception in async_server_base/async_connection during port scanning (nmap)#678vovams wants to merge 1 commit intocpp-netlib:0.12-releasefrom
vovams wants to merge 1 commit intocpp-netlib:0.12-releasefrom
Conversation
Member
Author
|
I can adapt the fix for 0.13, but what about 0.12? I wanted to merge the fix into it because i am using 0.12 in my project. |
Member
|
@glynos -- Do you think it's OK for us to pull this in then release a 0.12.1 to address just this issue? |
Member
|
@deanberris -- No, we agreed that some changes in 0.12 were mistakenly added, and reverted those changes in 0.13. We are slow to release a 0.13 version, but I think this should be a part of it. |
Member
|
Okay, SGTM. |
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix for issue #677.
During a port scan
async_server_base::handle_accept()may be called while the connection is not properly established. No error code is passed tohandel_accept()(i.e.!!ec == false) but the subsequent call toasync_connection::start()->stream_handler::remote_endpoint()->asio::basic_socket::remote_endpoint()fails with an exception.My fix is to add error checking by using
asio::basic_socket::remote_endpoint(asio::error_code&)overload instream_handler::remote_endpoint()and passing the error toasync_connection::start().Since i had to change signature of
stream_handler::remote_endpoint(), i added a new overload with old signature and behavior to keep any code which uses it working.