feat: update support Python versions#134
Conversation
github-actions
Bot
added
the
documentation
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 2
🧹 Outside diff range and nitpick comments (2)
pyproject.toml (1)
15-17: Fix inconsistent spacing around the new fieldThe new
requires-pythonfield has inconsistent spacing around it. Consider removing the extra blank lines to maintain consistent spacing with other fields in the section.authors = [ { name = "Brendan Doherty", email = "2bndy5@gmail.com" }, { name = "Peter Shen", email = "xianpeng.shen@gmail.com" }, ] - - requires-python = ">=3.9" - classifiers = [.github/workflows/run-dev-tests.yml (1)
44-44: Consider Python 3.13 testing strategyPython 3.13 is currently in development (alpha stage). While it's good to test against future versions, there are some considerations:
- It might cause unstable test results
- Some dependencies might not work with 3.13 yet
- GitHub Actions runners might not have stable support for 3.13
Consider either:
- Adding
continue-on-error: truefor Python 3.13 jobs- Or waiting until Python 3.13 reaches beta/RC stage
matrix: - py: ['3.9', '3.10', '3.11', '3.12', '3.13'] + py: ['3.9', '3.10', '3.11', '3.12'] + include: + - py: '3.13' + continue-on-error: true
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (3)
.github/workflows/run-dev-tests.yml(1 hunks)README.rst(2 hunks)pyproject.toml(1 hunks)
✅ Files skipped from review due to trivial changes (1)
- README.rst
🔇 Additional comments (1)
.github/workflows/run-dev-tests.yml (1)
44-44: Verify GitHub Actions runner compatibility
Let's verify that the selected GitHub Actions runners support Python 3.12 and 3.13.
✅ Verification successful
Python 3.12 and 3.13 are supported by the workflow configuration
The workflow uses actions/setup-python@v5 which officially supports Python 3.12 and 3.13-dev (as of December 2024). The workflow runs on ubuntu-22.04 and windows-latest, both of which are compatible with these Python versions through the setup-python action. The matrix configuration is correctly set up to test across all specified Python versions.
🏁 Scripts executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash
# Description: Check GitHub Actions runner images for Python version support
# Query GitHub API for runner image details
gh api graphql -f query='
{
repository(owner: "actions", name: "runner-images") {
object(expression: "main") {
... on Commit {
tree {
entries {
name
object {
... on Tree {
entries {
name
object {
... on Blob {
text
}
}
}
}
}
}
}
}
}
}
}' | jq -r '.data.repository.object.tree.entries[] | select(.name | test("(ubuntu|windows).*")).name'
Length of output: 610
Script:
#!/bin/bash
# Let's check the workflow file to understand which runner is being used
cat .github/workflows/run-dev-tests.yml
Length of output: 3433
2bndy5
left a comment
2bndy5
left a comment
There was a problem hiding this comment.
I was a little afraid because Ubuntu 20.04 LTS uses 3.8 by default, but that was bumped to 3.10 in Ubuntu 22.04.
Co-authored-by: Brendan <2bndy5@gmail.com>
This comment was marked as resolved.
This comment was marked as resolved.
|
Like this 9eeb03b? |
|
By the way. setup.py seems useless now since we have pyproject.toml, do you think I can remove it? |
Yeah! Let's see if the tests pass.
I'm leaving it there in case people try to install with an older version of pip (that does not support the latest PEPs). Since this is technically a minor version bump, I'd like to get this released with #131 feature as well (in v1.11.0). |
shenxianpeng
removed
documentation
shenxianpeng
changed the title
2 participants
Since Python 3.8 has already end of life (2024-10-07) https://devguide.python.org/versions
We might need to drop support it and also include Python 3.12 and 3.13
Summary by CodeRabbit
New Features
Chores