add parquet labels cache by yeya24 · Pull Request #6835 · cortexproject/cortex · GitHub
Skip to content

add parquet labels cache#6835

Merged
yeya24 merged 2 commits into
cortexproject:masterfrom
yeya24:parquet-labels-cache
Jun 30, 2025
Merged

add parquet labels cache#6835
yeya24 merged 2 commits into
cortexproject:masterfrom
yeya24:parquet-labels-cache

Conversation

@yeya24

@yeya24 yeya24 commented Jun 23, 2025

Copy link
Copy Markdown
Contributor

What this PR does:

Add Parquet Labels file cache using the caching bucket. This allows caching Parquet Labels File GetRange requests to reduce API calls to the object storage.

Which issue(s) this PR fixes:
Fixes #

Checklist

  • Tests updated
  • Documentation added
  • CHANGELOG.md updated - the order of entries should be [CHANGE], [FEATURE], [ENHANCEMENT], [BUGFIX]

@yeya24

yeya24 commented Jun 23, 2025

Copy link
Copy Markdown
Contributor Author

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For both, this and the chunks cache, should we cache also the attributes?

@yeya24 yeya24 Jun 29, 2025

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You can see that AttributesTTL already a config. It is part of the GetRange cache.

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh nice! missed that! thanks

yeya24 added 2 commits June 30, 2025 09:45
Signed-off-by: yeya24 <benye@amazon.com>
Signed-off-by: yeya24 <benye@amazon.com>
@yeya24 yeya24 force-pushed the parquet-labels-cache branch from 4365ff8 to 870ed1e Compare June 30, 2025 16:45
@dosubot dosubot Bot added the lgtm This PR has been approved by a maintainer label Jun 30, 2025
@yeya24 yeya24 merged commit 7435394 into cortexproject:master Jun 30, 2025
31 of 32 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

component/querier lgtm This PR has been approved by a maintainer size/L

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants