Add for tenant silences limit by SungJin1212 · Pull Request #6605 · cortexproject/cortex · GitHub
Skip to content

Add for tenant silences limit#6605

Merged
danielblando merged 1 commit into
cortexproject:masterfrom
SungJin1212:Add-silences-limit
Feb 26, 2025
Merged

Add for tenant silences limit#6605
danielblando merged 1 commit into
cortexproject:masterfrom
SungJin1212:Add-silences-limit

Conversation

@SungJin1212

@SungJin1212 SungJin1212 commented Feb 25, 2025

Copy link
Copy Markdown
Member

The prometheus alermanager PR, which included alertmanager v0.28.0, adds limits for silences.
This PR applies silence limits per tenant.
Follow up #6590

Which issue(s) this PR fixes:
Fixes #

Checklist

  • Tests updated
  • Documentation added
  • CHANGELOG.md updated - the order of entries should be [CHANGE], [FEATURE], [ENHANCEMENT], [BUGFIX]

@dosubot dosubot Bot added the lgtm This PR has been approved by a maintainer label Feb 25, 2025
Comment thread CHANGELOG.md Outdated

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you add the PR id?

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks

@rajagopalanand rajagopalanand left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Signed-off-by: SungJin1212 <tjdwls1201@gmail.com>
@danielblando danielblando merged commit 4704cfd into cortexproject:master Feb 26, 2025

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this the size for a single silence?

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The limit applies to each silence.
If one tenant has silences size of 100MB, 101MB, 102MB, and the limit is 200MB.
If a user adds a new silence with a size of 201MB, it fails.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

component/alertmanager lgtm This PR has been approved by a maintainer size/L

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants