Epif cleanup by jainvipin · Pull Request #16 · contiv/netplugin · GitHub
Skip to content

Epif cleanup#16

Merged
jainvipin merged 4 commits into
masterfrom
epif_cleanup
Feb 21, 2015
Merged

Epif cleanup#16
jainvipin merged 4 commits into
masterfrom
epif_cleanup

Conversation

@jainvipin

Copy link
Copy Markdown

@mapuri - can you please review these changes; this moves container runtime out of netplugin. This is one of the target code cleanup work we identified. Please ignore the request from contiv account.

Comment thread core/core.go Outdated

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggest to move the UpdateContainerId() out as well? Please ignore, if you were planning it for later.

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Update ContainerID is just a name of the function, there is nothing specific to container runtime there. I was hoping to not do updates to Ep record from oustide drivers code.

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hmm, it does imply that Endpoint driver Interface has something to do with containers, which is not the case.

Looks like this API updates the container-id in the EP oper-state in current implementation, should we just do it as part of attach/detach endpoint in the crt's logic? this looks more like some config meta for container runtime than network programming driver.

@jainvipin jainvipin merged commit 3ca8579 into master Feb 21, 2015
@jainvipin jainvipin deleted the epif_cleanup branch February 27, 2015 19:15
dseevr pushed a commit to dseevr-dev/netplugin that referenced this pull request Oct 24, 2017
dseevr pushed a commit to dseevr-dev/netplugin that referenced this pull request Nov 28, 2017
remove client dependency on modeldb
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants