{{ message }}
test(restart): drop outdated containerd 1.x plugin requirement from restart tests - #5185
Open
webdevsamran wants to merge 1 commit into
Open
test(restart): drop outdated containerd 1.x plugin requirement from restart tests#5185webdevsamran wants to merge 1 commit into
webdevsamran wants to merge 1 commit into
Conversation
…estart tests Signed-off-by: Samran Asif <samranwebdev2000@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Drops the outdated containerd 1.x
nerdtest.ContainerdPlugin("io.containerd.internal.v1", "restart", ...)requirement check from the restart-policy integration tests incmd/nerdctl/container/container_run_restart_linux_test.go.In containerd 2.x, the restart monitor is no longer registered under
io.containerd.internal.v1, causing these tests to silently skip during test runs.As discussed and approved in #5175 by @AkihiroSuda, dropping this stale gate enables the restart-policy tests to run on containerd 2.x.
Fixes #5175
AI coding assistance was used for initial investigation; changes were manually reviewed and compilation-tested.