{{ message }}
cri: remove restore in CreateContainer - #13871
Merged
samuelkarp merged 1 commit intoJul 31, 2026
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Removes the (previously deprecated) CRI CreateContainer checkpoint-restore path, eliminating the container-restore control flow and associated deprecation plumbing. This aligns CRI restore support with the newer Pod-level direction (KEP-5823 / RestorePod) referenced in the PR description.
Changes:
- Remove CRI CreateContainer-based checkpoint restore code paths (CreateContainer + StartContainer) and related status/deprecation wiring.
- Delete now-obsolete checkpoint-restore tests/scripts and the corresponding CI job step.
- Mark the deprecation entry as completed in
RELEASES.md.
Reviewed changes
Copilot reviewed 14 out of 14 changed files in this pull request and generated no comments.
Show a summary per file
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
samuelkarp
force-pushed
the
remove_deprecated_checkpoint_restore
branch
from
July 28, 2026 23:54
09c1dcd to
7e223f1
Compare
Contributor
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 14 out of 14 changed files in this pull request and generated no new comments.
Comments suppressed due to low confidence (1)
.github/workflows/ci.yml:560
- The CI step name still says "Checkpoint/Restore Disable via CRI", but this workflow no longer runs any restore coverage (and the invoked script now only tests checkpoint behavior). Renaming the step will avoid confusion when reading CI logs and job summaries.
- if: matrix.os != 'ubuntu-24.04-arm'
name: Checkpoint/Restore Disable via CRI
env:
Contributor
|
Could you explain why the container snapshot feature was removed? @samuelkarp |
Remove support for restoring checkpoint data during CreateContainer, which was previously deprecated in v2.3. Assisted-by: Antigravity Signed-off-by: Samuel Karp <samuelkarp@google.com>
samuelkarp
force-pushed
the
remove_deprecated_checkpoint_restore
branch
from
July 29, 2026 16:32
7e223f1 to
91be73b
Compare
Member
Author
Contributor
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 14 out of 14 changed files in this pull request and generated no new comments.
Comments suppressed due to low confidence (2)
internal/cri/server/container_create.go:135
- With checkpoint-restore support removed from CreateContainer, a caller that still passes a checkpoint archive path will now fail later with an image-store "failed to resolve image" error even when the file exists, which is harder to diagnose. Consider explicitly detecting the (previously supported) archive-path case and returning a clearer error pointing users to RestorePod (KEP-5823).
image, err := c.LocalResolve(config.GetImage().GetImage())
if err != nil {
return nil, fmt.Errorf("failed to resolve image %q: %w", config.GetImage().GetImage(), err)
.github/workflows/ci.yml:559
- This workflow step name still mentions "Checkpoint/Restore", but the restore path and related CI coverage were removed in this PR. Renaming the step makes CI output match what is actually being exercised.
name: Checkpoint/Restore Disable via CRI
mxpv
approved these changes
Jul 29, 2026
fuweid
approved these changes
Jul 31, 2026
github-project-automation
Bot
moved this from Needs Triage
to Review In Progress
in Pull Request Review
chrishenzie
approved these changes
Jul 31, 2026
github-project-automation
Bot
moved this from Review In Progress
to Done
in Pull Request Review
This was referenced Aug 7, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Remove support for restoring checkpoint data during CreateContainer, which was previously deprecated in v2.3.
This will conflict with #13822. If this PR lands first, #13822 will need to add back relevant code (and would be a good time to re-review it). If that one lands first, I can update this PR.