{{ message }}
Repository navigation
Conversation
najeebkp
marked this pull request as ready for review
September 30, 2026 10:12
Contributor
Contributor
Author
This also looks good. what if there are 10+ versions? |
Contributor
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request type
NOTE: Please remember to run
./gradlew spotlessApplyto fix any format violations.Changes in this PR
CCOR-13552 Create version-aware delete dialog
also connected with CCOR-13397, CCOR-13424 and CCOR-13432
Deleting from a list page removed only the latest version, leaving the definition listed at an older one. The dialog now asks which version to remove and says what survives. ConfirmChoiceDialog, which every confirmation renders through, loses the grey bands and gains a destructive treatment.
Two things, sharing one dialog.
Which version. List pages show one row per definition at its latest version, so a bare "delete" removed just that version and left the rest — it read as "the delete did nothing".
DeleteVersionedDialognow asks which version to remove, states the outcome ("Versions 2 and 1 will remain, and version 2 becomes the latest"), and offers all versions where an endpoint exists — schemas have one, workflows do not. A single-version definition shows no picker, since "that version" and "all versions" would be the same delete. Wired into Workflow Definitions and Schemas.One confirmation style. ConfirmChoiceDialog still wore the theme's grey title and action bands while UnsavedChangesDialog and ConfirmModal had each opted out of them. It now matches: no bands, a hairline footer,
one width, and a
destructiveflag giving deletes a trash badge and a red confirm button instead of "Confirm" with a save icon.destructivedefaults toisInputConfirmation, which is how the button colour was already chosen, so all 45 existing callers keep their behaviour — no call site changed.Adds tests for ConfirmChoiceDialog, which had none.
Verified in the browser against a local server: a versioned delete, a plain delete, and a non-destructive confirmation, with the DELETE requests.
Demo