refactor: set default_install_hook_types - #697
Conversation
|
Thanks for the PR! Could you point this PR to |
done |
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## master #697 +/- ##
==========================================
+ Coverage 97.37% 97.42% +0.04%
==========================================
Files 42 42
Lines 2022 2022
==========================================
+ Hits 1969 1970 +1
+ Misses 53 52 -1
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 1 file with indirect coverage changes Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report in Codecov by Sentry. |
|
Would you mind rebasing on top of |
|
isn't it already the case ? |
|
No, You can follow this instructions to rebase: #686 (comment) |
|
sorry I'm used to work in repositories where we squash merge PR so this is not considered as an issue. |
Lee-W
added
the
pr-status: ready-to-merge
3 participants
Description
Since pre-commit 2.18.0, it is possible to tell pre-commit which hook to install directly from the .pre-commit-config.yaml file. Thus I update the said file to apply the hooks according to the docs:
pre-commit install -t pre-commit -t pre-push -t commit-msg. I also updated the pre-commit version to make sure this parameter is available and finally updated the contributing documentation to make sure people simply use thepre-commit installcommand.bonus: there was a typo that I corrected (it's "stageS")
Checklist
./scripts/formatand./scripts/testlocally to ensure this change passes linter check and test