You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This PR follows #638 and extend the isolation to any GIT_ prefixed variables. It also ensure that every test requiring a tmp_git_project or tmp_commitizen_project fixture has it, even for test expecting a failure (to ensure the proper failure).
This fixes some false negatives in pre-commit as well as ordering side-effects for tests that were missing the fixture like this build failing on some totally unrelated (and untouched) cases.
There is few misc fixes and redundancy removal (lots of unnecessary nested .as_cwd() calls as well as some fixtures extracted into @pytest.mark.usefixtures() when not used in the test but still requiring the fixture setup))
Checklist
Add test cases to all the changes you introduce (N/A)
Run ./scripts/format and ./scripts/test locally to ensure this change passes linter check and test
Yes, #638 was using a temporary GIT_CONFIG_GLOBAL ensuring the clean configuration.
This PR extends the isolation to all GIT_ environment variables because some settings can be defined by both the configuration file and the environment. pre-commit is interfering with some of those, the git command is also exporting some depending on the version you use (see: https://github.com/pre-commit/pre-commit/blob/1f59f4cba8241ed7e572a1b5818bba74c6f31181/pre_commit/git.py#L27-L48), your shell can export some, your custom promt too, github actions can set some...
That's why without isolation you may have different behavior and some false negative depending on wether you are running in pre-commit or not, depending on your pre-commit version, depending on your git version, or depending of your own custom shell...
With this change, you ensure consistent and reproducible behavior on all environments, they always run with the minimal configuration (author and email) and no setting defined outside of the test case
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Lee-W
left a comment
Description
This PR follows #638 and extend the isolation to any
GIT_prefixed variables. It also ensure that every test requiring atmp_git_projectortmp_commitizen_projectfixture has it, even for test expecting a failure (to ensure the proper failure).This fixes some false negatives in
pre-commitas well as ordering side-effects for tests that were missing the fixture like this build failing on some totally unrelated (and untouched) cases.There is few misc fixes and redundancy removal (lots of unnecessary nested
.as_cwd()calls as well as some fixtures extracted into@pytest.mark.usefixtures()when not used in the test but still requiring the fixture setup))Checklist
./scripts/formatand./scripts/testlocally to ensure this change passes linter check and test