Add Unicode Support by adam-grant-hendry · Pull Request #615 · commitizen-tools/commitizen · GitHub
Skip to content

Add Unicode Support - #615

Closed
adam-grant-hendry wants to merge 39 commits into
commitizen-tools:masterfrom
adam-grant-hendry:feat/unicode
Closed

Add Unicode Support#615
adam-grant-hendry wants to merge 39 commits into
commitizen-tools:masterfrom
adam-grant-hendry:feat/unicode

Conversation

@adam-grant-hendry

Copy link
Copy Markdown
Contributor

Adds unicode support by allowing configurable encodings to be specified (defaults to utf-8).

Checklist

  • Add test cases to all the changes you introduce
  • Run ./scripts/format and ./scripts/test locally to ensure this change passes linter check and test
  • Test the changes on the local machine manually
  • Update the documentation for the changes

Fixes: Issue #516

This commit can be removed once `fix/ci` is merged into `master`.
This will allow commiting, e.g., emoji's and parsing commit messages for
unicode characters when creating change logs.
@codecov

codecov Bot commented Oct 23, 2022

Copy link
Copy Markdown

@adam-grant-hendry

Copy link
Copy Markdown
Contributor Author

@Lee-W @woile Please review at your earliest convenience. Thank you.

@Lee-W

Lee-W commented Oct 27, 2022

Copy link
Copy Markdown
Member

If I'm not mistaken, some of the changes are from #605. If that's the case, I'll review it after that one is merged and rebased to this. I browsed through this PR. I think we should be able to merge it soon as well :)

@adam-grant-hendry

Copy link
Copy Markdown
Contributor Author

If I'm not mistaken, some of the changes are from #605.

Correct. The first commit is a squash merge of #605 . I plan to revert it and rebase once #605 is approved and merged.

@Lee-W

Lee-W commented Nov 6, 2022

Copy link
Copy Markdown
Member

Hi @adam-grant-hendry , we've merged #605 . feel free to rebase this one when you have time. thanks!

adam-grant-hendry and others added 20 commits December 2, 2022 19:00
Specify `shell` as `bash` in `Run tests and linters` step.

Fixes: Issue commitizen-tools#604
`argcomplete` does not support Git Bash on Windows out of the box. For
details, see https://kislyuk.github.io/argcomplete/#git-bash-support.
`py -m` was added to command in `test_argcomplete_activation` during
experimentation and was forgotten to be removed.
Since Poetry 1.2.0 dependency groups are introduced, and `--dev` becomes deprecated, and instead `--with dev` has to be provided.
The current default setting for `tag_format` is `None`. This is not a
problem for the `bump` command, since the `normalize_tag` function
defaults to `$version` when no `tag_format` is passed. However it is a
problem for the `changelog` command, which seems to explicitly demand a
`tag_format` in order to run a rev-range lookup. This creates issues
like commitizen-tools#622.

Either a sane default needs to be set for `tag_format` or the
restriction in `changelog` has to be uplifted. In this commit the latter
has been chosen. A test is also implemented to check that `changelog`
will always compute a rev range with the default tag format.

Fixes commitizen-tools#622
This will allow commiting, e.g., emoji's and parsing commit messages for
unicode characters when creating change logs.
Switch `#!/bin/sh` to `#!/usr/bin/env sh` so scripts work on Windows as well as Linux and MacOS.
- Change shebang from `#!/bin/sh` to `#!/usr/bin/env sh`
- Set `$PREFIX` depending on OS
`argcomplete` does not support Git Bash on Windows out of the box. For
details, see https://kislyuk.github.io/argcomplete/#git-bash-support.
adam-grant-hendry and others added 15 commits December 2, 2022 19:04
This will allow commiting, e.g., emoji's and parsing commit messages for
unicode characters when creating change logs.
Specify `shell` as `bash` in `Run tests and linters` step.

Fixes: Issue commitizen-tools#604
This will allow commiting, e.g., emoji's and parsing commit messages for
unicode characters when creating change logs.
This will allow commiting, e.g., emoji's and parsing commit messages for
unicode characters when creating change logs.
This will allow commiting, e.g., emoji's and parsing commit messages for
unicode characters when creating change logs.
This will allow commiting, e.g., emoji's and parsing commit messages for
unicode characters when creating change logs.
This will allow commiting, e.g., emoji's and parsing commit messages for
unicode characters when creating change logs.
@adam-grant-hendry
adam-grant-hendry deleted the feat/unicode branch December 3, 2022 03:41
@adam-grant-hendry

Copy link
Copy Markdown
Contributor Author

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants