{{ message }}
chore(scripts): render cli_interactive tapes in parallel - #2010
Draft
bearomorphism wants to merge 1 commit into
Draft
chore(scripts): render cli_interactive tapes in parallel#2010bearomorphism wants to merge 1 commit into
bearomorphism wants to merge 1 commit into
Conversation
Contributor
bearomorphism
force-pushed
the
script-parallel-filter
branch
from
May 30, 2026 07:07
b274aaa to
fc38683
Compare
Contributor
🔍 Commitizen bump previewNo commits in this PR are eligible for a version bump. |
bearomorphism
force-pushed
the
script-parallel-filter
branch
from
May 30, 2026 07:23
fc38683 to
68fadd8
Compare
Collaborator
Author
|
Slimmer rewrite at 68fadd8: PR diff dropped from +151/-29 to +100/-29 by inlining helpers ( |
Contributor
🔍 Commitizen bump previewNo commits in this PR are eligible for a version bump. |
`scripts/gen_cli_interactive_gifs.py` now renders tapes through a ThreadPoolExecutor (default capped at `min(len(tapes), 4)`, override via `-j`), so a full re-render takes one slow tape's runtime instead of the sum of all five. Make `shared/base.tape` and `shared/cleanup.tape` use a per-tape `mktemp -d` workdir instead of the hardcoded `/tmp/commitizen-example`, so concurrent vhs runs do not race on the same directory. Generated-by: GitHub Copilot CLI (claude-opus-4.7-1m-internal) Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
bearomorphism
force-pushed
the
script-parallel-filter
branch
from
May 30, 2026 07:30
68fadd8 to
daffcb6
Compare
Contributor
🔍 Commitizen bump previewNo commits in this PR are eligible for a version bump. |
Collaborator
Author
4 tasks
bearomorphism
marked this pull request as draft
May 30, 2026 14:26
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Description
Follow-up to PR #2009 (deterministic gif regeneration) that makes local iteration faster:
Parallelism in
scripts/gen_cli_interactive_gifs.py. Tapes now render through aThreadPoolExecutorwith the default capped atmin(len(tapes), 4);-j Noverrides. Errors are reported per tape with a final summary instead of aborting on the first failure. The poe taskdoc:screenshotsstill callsgen_cli_interactive_gifs()with no args (zero-arg compatible signature), so nothing changes for the standardrender everythingpath.Per-tape workdir in
shared/base.tape+shared/cleanup.tape. Both files used to hardcode/tmp/commitizen-example, which would race once multiple tapes ran concurrently. Replaced withmktemp -d "${TMPDIR:-/tmp}/commitizen-example.XXXXXX"saved in a per-tape$WORKDIRshell variable and cleaned up at the end. Rendered gifs are unchanged (the setup runs insideHide).Checklist
Was generative AI tooling used to co-author this PR?
Generated-by: GitHub Copilot CLI (claude-opus-4.7-1m-internal) following the guidelines
Code Changes
uv run poe alllocally to ensure this change passes linter check and testspoe lintclean (ruff + mypy). Same pre-existing Windows-only flakes as PR ci(docspublish): make cli_interactive gif regeneration deterministic #2009 (gpg setup + a parallel-test race), unrelated to this change.python scripts/gen_cli_interactive_gifs.py --help-- argparse output renders.vhs validatepasses on all 5 tapes after theshared/patch.uv run poe doc:screenshotsis unchanged.Expected Behavior
uv run poe doc:screenshotscontinues to render all five interactive gifs (now in parallel, with the same outputs).python scripts/gen_cli_interactive_gifs.py [-j N]renders all tapes with up to N parallel workers (defaultmin(len(tapes), 4)).mktemp -ddirectory.Steps to Test This Pull Request
Additional Context
Depends conceptually on but does not require PR #2009 (deterministic gifs). The two PRs touch disjoint files except for
shared/base.tapeandshared/cleanup.tape, which only PR B modifies.