{{ message }}
fix: try to use ChainMap to chain settings, fix message_length_limit inconsistency#1812
Draft
bearomorphism wants to merge 1 commit intomasterfrom
Draft
fix: try to use ChainMap to chain settings, fix message_length_limit inconsistency#1812bearomorphism wants to merge 1 commit intomasterfrom
message_length_limit inconsistency#1812bearomorphism wants to merge 1 commit intomasterfrom
Conversation
bearomorphism
changed the title
message_length_limit inconsistency
woile
reviewed
Jan 19, 2026
Member
There was a problem hiding this comment.
Add some docstrings here:
- What is this
- What it does
- How to use
- How it compares to the previous solution
That would really help me understand the benefit.
Something I'd like to know as well:
Right now, if I make a plugin, I can create custom settings, but they are not typed. Would this allow plugin to declare their own settings?
example
Collaborator
Author
There was a problem hiding this comment.
Right now, if I make a plugin, I can create custom settings, but they are not typed. Would this allow plugin to declare their own settings?
Thanks, I will put those scenarios into consideration. ChainMap approach should not break the type system.
Collaborator
Author
There was a problem hiding this comment.
How it compares to the previous solution
We can discuss this in #1672. I will share the motivation there.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Relate #1672