{{ message }}
fix(bump)!: only add version files and staged changes#1261
Open
marcusalstrom wants to merge 4 commits intocommitizen-tools:v5from
Open
fix(bump)!: only add version files and staged changes#1261marcusalstrom wants to merge 4 commits intocommitizen-tools:v5from
marcusalstrom wants to merge 4 commits intocommitizen-tools:v5from
Conversation
BREAKING CHANGE: VersionProvider has new method which will break any custom version provider
…version providers
marcusalstrom
requested review from
Lee-W,
noirbizarre and
woile
as code owners
Member
|
As this is breaking change, I change the base branch to v4 |
Lee-W
reviewed
Nov 10, 2024
| """ | ||
|
|
||
| @abstractmethod | ||
| def get_files(self) -> list[str]: |
Member
There was a problem hiding this comment.
maybe renamed as version_files would be better?
Lee-W
added
pr-status: wait-for-modification
and removed
pr-status: wait-for-review
labels
Member
|
In general, I like this idea. @woile @noirbizarre would love to know your thought 🙂 |
Member
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Bump will now only add and commit version files along with any already committed changes. Any unstaged changes will remain unstaged.
NOTE: BREAKING CHANGE, since we added a new abstract method to VersionProvider any custom version provider will break. (open to any suggestions on how to avoid this)
Checklist
./scripts/formatand./scripts/testlocally to ensure this change passes linter check and testExpected behavior
Only version files and already staged changes will be committed on bump.
Steps to Test This Pull Request
Additional context
References issue #1194