{{ message }}
fix(pre-commit-hooks)!: allow empty ranges in 'commitizen-branch' - #1209
Merged
Conversation
woile
reviewed
Aug 16, 2024
Member
|
Looks good to me. but we probably won't want to bump a major version for it. so I would suggest we remove the ! in all the commits |
Contributor
Author
|
Thanks for the feedback. IMO this should be a ! change, as any user having Could go along other fixes such as #1206 and #1207 Example local usage until released: https://gitlab.com/RadianDevCore/tools/gcil/-/blob/53e6cb534ff77704ac9b9dc51d755b9965556910/.pre-commit-config.yaml#L54 |
Member
|
If that's the case, we'll need to wait for our next release. @woile we probably can create a v4 branch already? |
Bumps [ruff](https://github.com/astral-sh/ruff) from 0.6.1 to 0.6.2. - [Release notes](https://github.com/astral-sh/ruff/releases) - [Changelog](https://github.com/astral-sh/ruff/blob/main/CHANGELOG.md) - [Commits](astral-sh/ruff@0.6.1...0.6.2) --- updated-dependencies: - dependency-name: ruff dependency-type: direct:development update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com>
Details: 'args: [...]' is not able to access '-nr NO_RAISE' global
arguments for example from a arguments configuration
---
Signed-off-by: Adrian DC <radian.dc@gmail.com>
Details: Pushing the same history from 'develop' to 'staging' for
example fails because range 'origin/HEAD..HEAD' is empty
> No commit found with range: 'origin/HEAD..HEAD'
---
Signed-off-by: Adrian DC <radian.dc@gmail.com>
AdrianDC
force-pushed
the
hooks-branch-empty-range
branch
from
August 25, 2024 00:52
5885a04 to
5e4cbd6
Compare
Lee-W
approved these changes
Nov 10, 2024
Member
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
fix(pre-commit-hooks)!: move 'check' to 'args' for global options
Details: 'args: [...]' is not able to access '-nr NO_RAISE' global
arguments for example from a arguments configuration
fix(pre-commit-hooks)!: allow empty ranges in 'commitizen-branch'
Details: Pushing the same history from 'develop' to 'staging' for
example fails because range 'origin/HEAD..HEAD' is empty
Checklist
./scripts/formatand./scripts/testlocally to ensure this change passes linter check and testExpected behavior
Error
No commit found with range: 'origin/HEAD..HEAD'not raisedSteps to Test This Pull Request
Push same history to develop then staging