fix(commit): fix multiline commits with newlines#413
Conversation
|
I'm ok with using execa |
LinusU
force-pushed
the
fix-multiline-commits
branch
from
a1c26c6 to
8903010
Compare
|
Awesome! I'll send a separate PR with execa and some other small refactoring shortly :) merging this for now btw. I don't think we have ever talked about any "merge policy", I know that you don't have too much time so have been merging things as I see fit. I hope that this is okay, if you want to have some system where we give LGTM or approve commits that would be very fine for me as well 👍 |
|
That'd be great. I am open to a policy if that makes things easier. I generally release asap and am ok with you doing the same. I'm generally opposed to large releases and prefer to be small and nimble. |
|
That sounds great, I think keeping it as is will work good. I generally merge the smaller things, and stuff that I think that you might want to comment on I'll wait a bit with 👍
Couldn't agree more 👍 |
3 participants
This refactors
argsto always be an array, instead of converting it to a string with escaping and quoting. It usesspawninstead ofexecwhich takes an array of arguments instead of a string.I'm having some other strange issues with my local tests so uploading now to see how CI is...
Also, this fixes #411