fix(tools-api): pasteConfig.tags now supports a sanitize config#2100
Conversation
|
Thank you for addressing this issue! FWIW, I'd suggest using tools focused on XSS sanitization such as dompurify. |
@neSpecc I tried this solution but in that case, the configuration for sanitisation is as below: |
@jorgectf We are planning to integrate the library you recommended in our next release because accordingly, we need to update every tool with the API. So, this is just a hotfix right now. |
You should not create a config manually, it should be collected from tools. For example, Image tool should change |
Yup, I have done the same things I am just doing |
gohabereg
left a comment
There was a problem hiding this comment.
Would be great to cover it with unit tests
Co-authored-by: Peter Savchenko <specc.dev@gmail.com>
Co-authored-by: Jorge <46056498+jorgectf@users.noreply.github.com>
|
add a changelog describing fix and API change please |
|
The solution still does not work as expected. If a Tool does not specify the sanitizer config, all attributes should be removed. For now, it doesn't work. I'm digging into it. |
|
Seems ok for now. Will test it again tomorrow |
|
hey @neSpecc, Pls check and let me know when to merge. |

depends on next version of image tool and simple-image tool