Some refactoring in code_spell (extract method for long method code smell) by wangsiqidahaoren · Pull Request #3276 · codespell-project/codespell · GitHub
Skip to content

Some refactoring in code_spell (extract method for long method code smell)#3276

Open
wangsiqidahaoren wants to merge 3 commits into
codespell-project:mainfrom
wangsiqidahaoren:master
Open

Some refactoring in code_spell (extract method for long method code smell)#3276
wangsiqidahaoren wants to merge 3 commits into
codespell-project:mainfrom
wangsiqidahaoren:master

Conversation

@wangsiqidahaoren

Copy link
Copy Markdown

No description provided.

@DimitriPapadopoulos

Copy link
Copy Markdown
Collaborator

@wangsiqidahaoren

Copy link
Copy Markdown
Author

Thank you for this PR. This might need some more work to pass tests. Also, I'm not sure why you have moved codespell_lib/_codespell.py_codespell.py. Smaller changes might help review your changes.

Oh the move file is a mistake, I'm sorry that I didn't check it out. And the refactoring I made is to extract code block and make the source code more readable.

@DimitriPapadopoulos

Copy link
Copy Markdown
Collaborator

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants