iframe-proxy

EhabY · 2026-06-17T10:04:37Z

Summary

Adds coder.globalConfig as a machine-scoped directory setting for the CLI --global-config path, with CODER_CONFIG_DIR fallback and existing per-deployment storage as the default.
Applies the resolved config directory consistently through PathResolver, CLI auth flags, credential file reads/writes/deletes, active remote reload prompts, and support bundle settings.
Preserves keyring precedence while allowing file-backed CLI credentials to be reused when keyring auth is not active.

Closes #185.

Testing

pnpm test:extension ./test/unit/cliConfig.test.ts ./test/unit/core/pathResolver.test.ts ./test/unit/core/cliCredentialManager.test.ts ./test/unit/login/loginCoordinator.test.ts ./test/unit/supportBundle/settings.test.ts
pnpm test
pnpm typecheck
pnpm lint
pnpm format:check
pnpm build
git diff --check

Generated by Coder Agents.

Implementation plan

Add a dedicated coder.globalConfig setting for a directory path and keep coder.globalFlags from overriding managed --global-config / --use-keyring flags.
Resolve global config path in PathResolver: coder.globalConfig first, then CODER_CONFIG_DIR, then the existing <globalStorage>/<safeHostname> default.
Preserve keyring precedence in CLI auth resolution; use --url for active supported keyring auth, otherwise --global-config <resolvedDir>.
Read file-backed CLI credentials from the resolved config directory when keyring auth is not active so CLI login can be shared with the extension.
Add reload prompt/support bundle handling for the setting.
Cover behavior with targeted unit tests for path resolution, CLI flags, credential manager, login fallback, and support bundle settings.

EhabY · 2026-06-24T09:42:34Z

With 7e5d315 we have the following. @code-asher I think this simplified things a bit and we can further cut down if we drop support for <0.25 (very old tbh - 3 years old).

Global config / credential changes (vs `main`)

<dir> = the per-deployment config dir, default <globalStorage>/<safeHost>, or a user --global-config in coder.globalFlags (honored on 2.31.0+, file mode only).

WRITE

Mode / version	`main`	new
keyring (mac/win, 2.29+)	`coder login --use-token-as-session <url>`	same
file, 0.25+	extension writes `<dir>/session` + `<dir>/url`	`coder login --use-token-as-session <url> --global-config <dir>`
file, <0.25	extension writes the files	extension writes the files (fallback)

READ

Mode / version	`main`	new
keyring (2.31+)	`coder login token --url <url>`	same
file, 2.31+	nothing (only keyring was read)	`coder login token --url <url> --global-config <dir>`
<2.31	nothing	nothing

DELETE

rm <default> files always runs: it is the only deleter when coder logout is unavailable (<0.25 or binary unresolvable), and it sweeps the default dir, which coder logout --global-config <override> does not touch.

Mode / version	`main`	new
keyring (2.29+)	`coder logout --url <url> --yes` + rm `<default>` files	same
file, 0.25+	rm `<default>` files only	`coder logout --url <url> --global-config <dir> --yes` + rm `<default>` files
file, <0.25 / no binary	rm `<default>` files	rm `<default>` files (no `coder logout`)

Config dir / `--global-config`

	`main`	new
Custom dir	not configurable	`--global-config` in `coder.globalFlags` (2.31+, file mode)
Binary cache	under `<default>`	always plugin dir (`coder.binaryDestination` still applies)

What it means for the user (vs `main`)

New: point the extension at a shared CLI dir (--global-config=~/.config/coderv2 in coder.globalFlags) to share login with the terminal coder, on 2.31+.
New: on 2.31+ the extension picks up file based CLI credentials (main only read the keyring).
File writes/deletes now go through coder login / coder logout instead of the extension touching the files directly.
No change for keyring users.

Split src/util.ts into focused modules: src/util/uri.ts (toSafeHost, removeTrailingSlashes, resolveUiUrl, openInBrowser) and src/util/authority.ts (Remote SSH authority helpers), replacing src/uri/utils.ts. Migrate all importers and mirror the unit tests. Make CliCredentialManager.readToken return the token together with its source ("keyring" | "files") so LoginCoordinator labels the login method from the actual source instead of re-deriving it from whether keyring is enabled.

…malization - Add loginCoordinator test for the keyring_token method (source: "keyring") - Add comprehensive toRemoteAuthority tests over varied URI types - Test toSafeHost/normalizeUrl with Arabic alongside Japanese IDNs - Consolidate the trim + strip-trailing-slashes logic into a shared normalizeUrl in util/uri, reused by resolveUiUrl and cliCredentialManager

Replace the dedicated `coder.globalConfig` setting with a `--global-config` passthrough in `coder.globalFlags`, honored on 2.31.0+. The extension no longer reads/writes the CLI credential files itself: it writes via `coder login` (0.25.0+, `--use-token-as-session`), reads via `coder login token` (2.31.0+), and deletes via `coder logout` (keyring or file with `--global-config`). Direct file writes remain only as a pre-0.25 fallback. The binary cache no longer follows the config dir.

- Bump the minimum supported deployment version to 0.25.0 (where `coder login` lives), gating on `featureSet.cliLogin`, and move the compatibility check before credential configuration so older servers get a clear message. - Remove the pre-0.25 direct-file-write fallback; credential writes now always go through `coder login`. Drop the now-unused `vscodessh` feature flag and the dead `CredentialFileError` class plus its `filesystem`/`file` telemetry categories. - Collapse the `resolveCli` overloads into one throwing resolver; the best-effort read path catches instead. - Fix the stale `coder.globalConfig` CHANGELOG entry (the setting was dropped) and two pre-existing test typecheck breaks (`toSafeHost` import path and a `CliAuth.allowOverride` literal).

Routing file-mode credentials through `coder login`/`logout` means the credential binary resolver now runs in the login and logout flows, not just on connect. It previously fell back to `fetchBinary` on a cache miss, so a file-mode user's login (including auto-login on startup) or logout could trigger a surprise CLI download with a progress popup, where before it was silent file I/O. Make the resolver locate-only. The connect and CLI-command flows still fetch the binary first, so credential ops become best-effort against an already-present binary and never download on their own. If no binary exists yet, credential sharing is simply skipped until a real connection fetches one.

EhabY · 2026-06-25T11:00:36Z

+				// Locate-only: never download from credential ops; the connect and
+				// CLI-command flows fetch the binary first.
+				return this.cliManager.locateBinary(url);


locate-only means a keyring user with no binary yet won't get their terminal token picked up at first login until something fetches the binary (main would download for them). Keep it, or revert to download-on-demand?

I'm hesitant about downloading on login/logout because that doesn't seem very UX friendly

Yeah I think this is good, if the binary is missing then there is no credential share/sync (yet) and that seems fair to me.

Hrm I tested and I guess it could be a little weird for first time login because if you set a global config to share with a cli you already have downloaded and configured, it does not work because VS Code has not downloaded a binary yet.

Which I think means the read feature will basically never be useful, because pretty much the one time you need to read the login is when you have never logged in before. 🤔 (I think??)

Yeaaah it's less useful now but consistent (CLI always does the action). It could be useful still if they login every day for example so they will have the CLI but the token will be taken from the CLI login

code-asher · 2026-06-25T19:31:25Z

+	// Honor a user `--global-config` only when allowOverride (file mode, 2.31+);
+	// otherwise strip it and emit our own so it matches where we read/write.
+	const honorOverride =
+		auth.mode === "global-config" &&
+		auth.allowOverride &&
+		userFlags.some((flag) => isFlag(flag, "--global-config"));


Why are we not able to allow the override with the keyring?

Currently we happen to know the CLI only stores a url and token there, but this could change in the future. No harm in letting it be set, I think.

And to take it a bit further, IMO a config dir is better than --url because the user can run the CLI directly as well (like for example say we decide to expose it on PATH in the terminal or something so users can run commands directly).

Because we have a setting coder.useKeyring, if we allow --global-config to pass through then this will result in hiding the user setting above. I am confused by the --url point though, like if we do not pass --global-config then the CLI defaults to keyring which is why we need to pass --url

- rename FeatureSet.keyringTokenRead to tokenRead (token subcommand works for both stores) - rename resolveUiUrl to resolveCoderDashboardUrl - clarify openInBrowser docstring (connectionUrl is arbitrary) - split buildGlobalFlags on auth mode to drop the nested ternary

EhabY self-assigned this Jun 17, 2026

EhabY requested a review from code-asher June 17, 2026 12:46

code-asher reviewed Jun 17, 2026

View reviewed changes

Comment thread src/core/cliCredentialManager.ts Outdated

Comment thread src/core/cliCredentialManager.ts Outdated

Comment thread src/core/cliCredentialManager.ts Outdated

Comment thread src/core/pathResolver.ts Outdated

EhabY requested a review from code-asher June 18, 2026 10:00

EhabY force-pushed the feat/global-config branch 3 times, most recently from 9a72ccf to 6d03c00 Compare June 23, 2026 06:59

EhabY force-pushed the feat/global-config branch from 7e5d315 to 36cfde3 Compare June 24, 2026 09:48

EhabY and others added 5 commits June 25, 2026 12:47

feat: support configurable CLI global config

d48a19c

refactor: address global config review feedback

69001b0

EhabY force-pushed the feat/global-config branch from 36cfde3 to b69b20b Compare June 25, 2026 09:47

EhabY added 2 commits June 25, 2026 13:43

EhabY commented Jun 25, 2026

View reviewed changes

code-asher approved these changes Jun 25, 2026

View reviewed changes

Sunbelt Computer Software

PL/B Language Development and Support

Uh oh!

Conversation

EhabY commented Jun 17, 2026

Summary

Testing

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

EhabY commented Jun 24, 2026

Global config / credential changes (vs main)

WRITE

READ

DELETE

Config dir / --global-config

What it means for the user (vs main)

Uh oh!

EhabY Jun 25, 2026

Choose a reason for hiding this comment

Uh oh!

code-asher Jun 25, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

code-asher Jun 25, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

code-asher Jun 25, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

EhabY Jun 25, 2026

Choose a reason for hiding this comment

Uh oh!

code-asher Jun 25, 2026

Choose a reason for hiding this comment

Uh oh!

EhabY Jun 25, 2026

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Global config / credential changes (vs `main`)

Config dir / `--global-config`

What it means for the user (vs `main`)

code-asher Jun 25, 2026 •

edited

Loading

code-asher Jun 25, 2026 •

edited

Loading

code-asher Jun 25, 2026 •

edited

Loading