{{ message }}
feat: add mode-aware mouse encoding - #12
Open
pmarreck wants to merge 2 commits into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Summary
encodeMouse(event, options)on each terminal instanceBufferbytes suitable for writing to the child PTYCoverage
Tests cover X10 tracking, normal tracking with X10 wire format, UTF-8, URXVT, SGR, SGR-pixels, press/release/motion, modifiers, buttons 1 through 11, mode transitions, disabled and suppressed events, out-of-viewport drags, same-cell motion deduplication, invalid input sets, and disposal.
A deliberate mutation that stopped resynchronization after
feed()made the negotiated-mode regression test fail. An earlier implementation that reapplied unchanged geometry made the motion-dedup test fail, which is why the binding caches geometry.Verification
npm run build:nativenpm run buildnpm run verify