refactor!: remove default organization model routes - #28632
Conversation
95aa29d to
d5c5aa8
Compare
Docs previewCheck off each page once it's been reviewed. If a page changes in a later push, its checkbox clears automatically so it gets a fresh look. Pages not yet wired into the docs navigation aren't listed here. |
d5c5aa8 to
edc8c08
Compare
ethanndickson
changed the title
github-actions
Bot
added
the
release/breaking
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: edc8c086d7
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
|
@codex review |
|
Codex Review: Didn't find any major issues. What shall we delve into next? Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
Address review feedback on the /api/v2 chat promotion: - Collapse the per-group chat register helpers into a single registerChatAPIRoutes mounted once per API prefix, inverting the unpromoted experimental routes and the /api/v2 404 reservations into chat_routes.go behind a chatAPIPrefix selector. Merge the MCP OAuth2 helper pair and fold the organization MCP server config routes into registerOrganizationChatRoutes. - Keep GET /chats/models experimental-only instead of promoting it: the organization-scoped models collection supersedes it and #28632 removes it. /api/v2/chats/models now 404s via a segment reservation. - Reword the MCP OAuth2 callback TODO: providers pin the redirect URI for existing sessions, so promotion needs a re-auth story rather than a redirect URI migration. - Fold the chat file @produce exceptions into the swagger parser's existing no-response-model exception list.
GET /chats/models is no longer promoted to /api/v2 (superseded by the organization-scoped collection; #28632 removes it), so point the disclosure comparison back at the experimental path.
|
Heads up: review feedback on #28496 (968b807) moved the default-organization model routes you're removing here. They're no longer registered inline in coderd.go; the /chats/model-configs and /chats/models mounts now live in coderd/chat_routes.go inside the experimental branch of registerChatAPIRoutes, and GET /chats/models is no longer promoted to /api/v2 (it 404s there via a segment reservation). Expect a conflict in that file when you restack, and the /models v2 reservation can go away entirely once this lands after the compatibility window.
|
GET /chats/models is no longer promoted to /api/v2 (superseded by the organization-scoped collection; #28632 removes it), so point the disclosure comparison back at the experimental path.
b968673 to
a19d675
Compare
|
@codex review |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: a19d6755bc
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
a6ec22e to
06dcc05
Compare
|
@codex review |
|
Codex Review: Didn't find any major issues. More of your lovely PRs please. Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
06dcc05 to
e1140af
Compare
e1140af to
9f460fd
Compare
|
Updated this branch by merging the new base tip @codex review Please review current head
|
|
Codex Review: Didn't find any major issues. Swish! Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
|
Merged the updated base (which now includes main and the #28593 conflict resolution, see #28542). No conflicts on this branch; @codex review Please review current head
|
|
Codex Review: Didn't find any major issues. Chef's kiss. Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
3f5fedf to
76d8c5e
Compare
|
@codex review |
76d8c5e to
f513360
Compare
2 participants
Important
Most of the added lines in this PR are generated API reference content for publishing the organization-scoped
GETandPOST /api/v2/organizations/{organization}/chats/modelsreplacements. There is no matching generated-doc deletion because the three removed default-organization endpoints are experimental and are not present in the generated public API reference on the current base. The removed paths remain only as explicit 404 reservations, with no default-organization shim or functional handler.Summary
Remove the unused default-organization chat model collection routes:
Use the organization-scoped collection instead:
Context
The intention of PR #28440 was to consolidate model availability into the organization-scoped models collection for CODAGT-898 and remove the superseded collection routes. That PR removed
/organizations/{organization}/chats/models/available, but it missed these older default-organization routes and explicitly retained one of them. This PR completes the intended #28440 cutover. The repository has no SDK, CLI, or frontend consumer for the removed routes.This change also prevents PR #28496 from promoting the missed default-organization
/chats/modelsroute into the stable/api/v2API.This change is separate from the one-release
/api/experimentalcompatibility window in CODAGT-921. That window preserves experimental versions of the intended stable API. It does not require compatibility routes for unused deployment-scoped endpoints.Refs CODAGT-898.
Breaking change
Clients that call the removed routes must use the organization-scoped model collection and provide an organization.
Changelog
Remove unused default-organization Coder Agents model API routes. API clients must use the organization-scoped chat models collection.
Note
Coder Agents generated this pull request on Ethan Dickson's behalf.