{{ message }}
fix: update disabled state on AI provider rows - #28558
Merged
Merged
Conversation
Move the enabled/disabled state out of the status column: disabled providers now show a Disabled badge beside the name with a muted avatar and disabled text for the name and base URL. The status column keeps only the issue badges. Replace the native title tooltip on the Not supported in Agents badge with the shared Tooltip component so it matches the warning tooltip, and constrain tooltip width so long warnings wrap.
Render the tooltip trigger badges as native buttons via Badge asChild so they expose a control role to assistive technology instead of a bare focusable div, and render the Disabled badge as a span to avoid a div inside AvatarData's inline title.
tracyjohnsonux
marked this pull request as ready for review
August 25, 2026 18:15
ibetitsmike
reviewed
Aug 26, 2026
ibetitsmike
left a comment
ibetitsmike
left a comment
Collaborator
There was a problem hiding this comment.
Disclosure: This review was researched and written by Xum, an AI coding agent, acting for @ibetitsmike.
Ran the repo frontend-review audit (FE1-FE10) over the merge-base diff (3 files under site/src/).
FE1 PASS Disabled story added; NotSupportedInAgents + WithHostnameCollisionWarning play fns exercise the new states
FE2 PASS AIProvider from api/typesGenerated; no any / casts / non-null assertions
FE3 PASS Badge / Tooltip / Avatar / Table primitives reused
FE4 PASS event-bubbling isolation comments explain rationale
FE5 PASS enabled / disabled / warning / unsupported states covered
FE6 PASS status badges are semantic button triggers; accessible names lead with visible text
FE7 PASS n/a - no query changes
FE8 PASS n/a - no effects
FE9 PASS MockAIProvider spread from testHelpers
FE10 PASS role/text queries only
Notes:
- Tooltip triggers stop click/keydown/keyup propagation so
useClickableTableRownavigation is not hijacked - nice. - Pre-existing, untouched:
isLoading || isFetchingatProvidersPageView.tsx:113.
Verdict: clean per the FE rule contract; no blocking findings. CI green at a473261f.
…-row-state # Conflicts: # site/src/pages/AISettingsPage/ProvidersPage/components/ProviderRow.stories.tsx # site/src/pages/AISettingsPage/ProvidersPage/components/ProviderRow.tsx
… into ai-providers-disabled-row-state
tracyjohnsonux
enabled auto-merge (squash)
August 26, 2026 18:28
ibetitsmike
approved these changes
Aug 26, 2026
tracyjohnsonux
changed the title
tracyjohnsonux
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Updates the AI providers list to make the disabled state visible on the row itself. Disabled providers show a
Disabledbadge beside the name, a muted avatar, and disabled text for the name and base URL. TheEnabledbadge is removed from the status column, which now holds only issue badges (Not supported in AgentsandWarning).Also fixes tooltip inconsistency in the status column: the
Not supported in Agentsbadge used a nativetitleattribute while the warning used the shared Tooltip component, so they looked different. Both now use the shared tooltip, with a max width so long warnings wrap instead of rendering as one long line.Storybook interaction coverage: new
Disabled/Enabledstories, andNotSupportedInAgentsnow hovers the badge and asserts the shared tooltip content.Created by Coder Agents on behalf of @tracyjohnsonux.