{{ message }}
Conversation
Contributor
|
All contributors have signed the CLA ✍️ ✅ |
Contributor
Author
|
I have read the CLA Document and I hereby sign the CLA |
cdrci2
added a commit
to coder/cla
that referenced
this pull request
Aug 24, 2026
hwang251
changed the title
Contributor
Author
hwang251
added
backport
backport/v2.34
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
ExtractWorkspaceAgentAndLatestBuildcomputed the workspace owner's RBAC subject viaUserRBACSubject, but discarded the returned user status. As a result, workspace agent requests were still authorized even when the owner's account was suspended.This change captures
userStatusand rejects the request with401 Unauthorizedwhen the owner is notActive, returning a clear message directing the user to contact an admin to reactivate the account.Changes
coderd/httpmw/workspaceagent.go: stop discarding the owner status fromUserRBACSubject; return401when the owner is not active.coderd/httpmw/workspaceagent_test.go: add anInactiveUsertest that suspends the owner and asserts a401with the expected message.Testing
TestWorkspaceAgent/InactiveUserunit test covers the suspended-owner path.