{{ message }}
fix: prevent coderd crashes from unsupported Tailnet RPCs - #28429
Merged
geokat merged 1 commit intoSep 3, 2026
Merged
Conversation
geokat
force-pushed
the
george/plat-464/prevent-coderd-crashes-from-unsupported-tailnet-rpcs
branch
from
August 21, 2026 01:34
1560d81 to
7630cbb
Compare
geokat
marked this pull request as ready for review
August 21, 2026 01:45
geokat
requested review from
Emyrk,
deansheather and
jdomeracki-coder
and removed request for
deansheather
August 21, 2026 01:45
dylanhuff-at-coder
approved these changes
Sep 3, 2026
Workspace agents could call Tailnet RPCs whose providers were nil, causing a panic in a DRPC handler and terminating coderd. Restrict agent connections to supported Tailnet RPCs and return Unimplemented when optional providers are unavailable. Wrap Coder DRPC servers with panic recovery so a future handler panic returns an internal error instead of crashing the process. Add wire-level and agent-RPC regression coverage. Refs: https://linear.app/codercom/issue/PLAT-464
geokat
force-pushed
the
george/plat-464/prevent-coderd-crashes-from-unsupported-tailnet-rpcs
branch
from
September 3, 2026 20:10
7630cbb to
75ff75d
Compare
geokat
deleted the
george/plat-464/prevent-coderd-crashes-from-unsupported-tailnet-rpcs
branch
September 3, 2026 20:29
geokat
added
backport
backport/v2.36
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Workspace agents could call RefreshResumeToken and WorkspaceUpdates, even though agent connections do not configure the providers those RPCs require. The resulting nil dereference panicked a DRPC handler and crashed coderd.
Limit the agent Tailnet surface to its supported RPCs, return
Unimplementedwhen optional providers are absent, and recover panics in Coder-owned DRPC servers so they return an internal error instead of crashing the process.Refs: https://linear.app/codercom/issue/PLAT-464