feat(site/src/pages/AgentsPage/components/ChatsSidebar): move PR icon to diff line, center unread dot, persist kebab by tracyjohnsonux · Pull Request #28326 · coder/coder · GitHub
Skip to content

feat(site/src/pages/AgentsPage/components/ChatsSidebar): move PR icon to diff line, center unread dot, persist kebab - #28326

Merged
tracyjohnsonux merged 4 commits into
mainfrom
tracy/sidebar-pr-icons-kebab-dot
Aug 19, 2026
Merged

feat(site/src/pages/AgentsPage/components/ChatsSidebar): move PR icon to diff line, center unread dot, persist kebab#28326
tracyjohnsonux merged 4 commits into
mainfrom
tracy/sidebar-pr-icons-kebab-dot

Conversation

@tracyjohnsonux

@tracyjohnsonux tracyjohnsonux commented Aug 19, 2026

Copy link
Copy Markdown
Contributor

Three chat-sidebar row updates cherry-picked from #28317 (that PR stays open as the full riff), plus one removal:

  • PR icon moves to the diff line. The linked pull request icon (open / draft / merged / closed) no longer replaces the status icon when the chat is idle. It renders on the second line next to the +additions -deletions stats, in both the sidebar tree and the chat search results, regardless of chat status.
  • Unread dot alignment. The unread dot is centered in a box matching the kebab's width, so it sits on the same axis as the actions trigger instead of shifting when the hover swap happens.
  • Persistent kebab on the selected chat. The row actions trigger stays visible on the active chat (no hover required, reachable on touch devices); the timestamp is hidden there. Other rows keep the hover swap.
  • Subagent count badge removed. The N + bot icon added to the metadata line in feat(site/src/pages/AgentsPage): surface subagents in the chat sidebar #28234 no longer renders, making room for the PR icon and diff stats. The "Show subagents" menu toggle and expand behavior are unchanged.

Status and PR icons carry role="img" with accessible labels ("Idle", "Pull request merged", ...).

Implementation notes
  • statusConfig.ts: getChatDisplayConfig(chat) now returns the status icon plus a separate prIcon config (icon, className, accessible label) instead of letting the PR icon take precedence over the status. Labels added for all status and PR states.
  • ChatTreeNode.tsx / ChatSearchResults.tsx: render prIcon on the second line before the line stats.
  • Kebab persistence reuses the existing isActiveChat value: opacity-100 on the trigger, hidden on the timestamp for the active row.
  • ChatTreeNode.tsx: the on-row subagent count badge (childIDs.length + BotIcon) is removed; the SubagentsMenuToggle story only asserts the menu toggle, so it still passes.
  • Not included from feat(site): move PR icon to diff line, add subagent status icons, persist kebab on active chat #28317: the subagent status icon variants (CheckCheckIcon / SubagentsLoaderIcon, the hasSubagents param, and the WithSubagentStatusIcons story).

Validation:

  • pnpm run lint (biome, tsc, knip, circular deps, compiler): pass
  • Story tests: 96 passed (4 files) including the updated WithPRStateIcons label assertions and the new ActiveChatKebabPersistent story
  • Unit suite for the sidebar area: 65 passed
  • make pre-commit (via git hook): pass

Generated by Coder Agents on behalf of @tracyjohnsonux.

… to diff line, center unread dot, persist kebab

The linked pull request icon (open, draft, merged, closed) now renders on
the second line next to the diff stats in both the sidebar tree and the
chat search results, instead of replacing the status icon when idle. The
unread dot is centered on the kebab axis so it stops jumping when the
actions trigger swaps in. The row actions trigger stays visible on the
selected chat without hovering, and the timestamp is hidden there.

Cherry-picked from #28317 without the subagent status icon variants.
…ent count badge from chat row metadata line

The count and bot icon added in #28234 no longer render on the second
line, making room for the PR icon and diff stats. The "Show subagents"
menu toggle and expand behavior are unchanged.
@tracyjohnsonux
tracyjohnsonux enabled auto-merge (squash) August 19, 2026 20:50
@tracyjohnsonux
tracyjohnsonux merged commit 5be2fa7 into main Aug 19, 2026
22 checks passed
@tracyjohnsonux
tracyjohnsonux deleted the tracy/sidebar-pr-icons-kebab-dot branch August 19, 2026 21:02
@github-actions github-actions Bot locked and limited conversation to collaborators Aug 19, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants