docs: fix Helm TLS/ingress value keys in admin/setup by nickvigilante · Pull Request #28087 · coder/coder · GitHub
Skip to content

docs: fix Helm TLS/ingress value keys in admin/setup - #28087

Merged
nickvigilante merged 1 commit into
mainfrom
vigilante/docs-643-docs-fix-helm-tlsingress-value-keys-in-adminsetup
Aug 14, 2026
Merged

docs: fix Helm TLS/ingress value keys in admin/setup#28087
nickvigilante merged 1 commit into
mainfrom
vigilante/docs-643-docs-fix-helm-tlsingress-value-keys-in-adminsetup

Conversation

@nickvigilante

Copy link
Copy Markdown
Contributor

What

Fix the Helm values in the TLS setup step of docs/admin/setup/index.md. The documented keys are silently ignored by the chart, so TLS appears configured but isn't.

Changes

  • coder.tls.secretName (singular) → coder.tls.secretNames (a list). The chart key is secretNames.
  • coder.ingress.secretName / coder.ingress.wildcardSecretName → nested under coder.ingress.tls.secretName / coder.ingress.tls.wildcardSecretName, where the chart actually reads them.
  • Added coder.ingress.tls.enable: true so the ingress-termination example actually enables TLS.

All keys verified against helm/coder/values.yaml on main (coder.tls.secretNames, coder.ingress.tls.{enable,secretName,wildcardSecretName}). Surfaced by the runtime drift sweep. The example now parses to the correct chart structure.

Linear: DOCS-643

This PR was created with AI assistance (Coder Agents).

The setup guide used chart keys Helm silently ignores: coder.tls.secretName (singular) should be coder.tls.secretNames (a list), and coder.ingress.secretName/wildcardSecretName belong under coder.ingress.tls.{secretName,wildcardSecretName}. Also set coder.ingress.tls.enable so the ingress TLS example actually terminates TLS. Keys verified against helm/coder/values.yaml. Fixes DOCS-643.

> This PR was created with AI assistance (Coder Agents).
@linear-code

linear-code Bot commented Aug 12, 2026

Copy link
Copy Markdown

@github-actions

Copy link
Copy Markdown
Contributor

@nickvigilante
nickvigilante marked this pull request as ready for review August 14, 2026 16:21

@BobbyHo BobbyHo left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@nickvigilante
nickvigilante merged commit 5b97d99 into main Aug 14, 2026
52 of 53 checks passed
@nickvigilante
nickvigilante deleted the vigilante/docs-643-docs-fix-helm-tlsingress-value-keys-in-adminsetup branch August 14, 2026 16:43
@github-actions github-actions Bot locked and limited conversation to collaborators Aug 14, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants