fix(site): include owner context in Agents org picker permission check by ibetitsmike · Pull Request #28076 · coder/coder · GitHub
Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 7 additions & 1 deletion site/src/api/queries/organizations.ts
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,7 @@ import {
within,
} from "storybook/test";
import { API } from "#/api/api";
import { permittedOrganizationsKey } from "#/api/queries/organizations";
import type * as TypesGen from "#/api/typesGenerated";
import { ConfirmDialog } from "#/components/Dialog/ConfirmDialog/ConfirmDialog";
import { MockChatModelConfig } from "#/testHelpers/chatModels";
Expand All @@ -24,12 +25,10 @@ import {
} from "../utils/reasoningEffort";
import { AgentCreateForm } from "./AgentCreateForm";

// Query key used by permittedOrganizations() in the form.
const permittedOrgsKey = [
"organizations",
"permitted",
{ object: { resource_type: "chat" }, action: "create" },
];
const permittedOrgsKey = permittedOrganizationsKey({
object: { resource_type: "chat", owner_id: "me" },
action: "create",
});

const modelConfigID = "model-config-1";
const claudeModelConfigID = "model-config-claude";
Expand Down Expand Up @@ -1104,3 +1103,49 @@ export const PermittedOrgsResolvesToSubset: Story = {
expect(options.organizationId).toBe(MockOrganization2.id);
},
};

/**
* Member-scoped roles like agents-access grant chat:create only on
* chats the user owns, so the per-org check must carry owner context
* for the picker to render.
*/
export const MemberScopedPermissionsShowOrgPicker: Story = {
parameters: {
showOrganizations: true,
organizations: [MockDefaultOrganization, MockOrganization2],
},
beforeEach: () => {
spyOn(API, "getOrganizations").mockResolvedValue([
MockDefaultOrganization,
MockOrganization2,
]);
spyOn(API, "checkAuthorization").mockImplementation(async ({ checks }) =>
Object.fromEntries(
Object.entries(checks).map(([id, check]) => [
id,
check.object.owner_id === "me",
]),
),
);
},
play: async ({ canvasElement }) => {
const canvas = within(canvasElement);
const picker = await canvas.findByRole(
"button",
{ name: /^Organization:/ },
{ timeout: 3000 },
);
Comment thread
ibetitsmike marked this conversation as resolved.
await userEvent.click(picker);
await screen.findByRole("option", {
name: MockDefaultOrganization.display_name,
});
await userEvent.click(
screen.getByRole("option", { name: MockOrganization2.display_name }),
);
expect(
canvas.getByRole("button", {
name: `Organization: ${MockOrganization2.display_name}`,
}),
).toBeInTheDocument();
},
};
2 changes: 1 addition & 1 deletion site/src/pages/AgentsPage/components/AgentCreateForm.tsx
Loading