{{ message }}
refactor: make user AI budget and spend endpoints consistent - #27611
Merged
Conversation
Contributor
ssncferreira
changed the title
ssncferreira
force-pushed
the
ssncf/refactor-user-spend-limit
branch
from
July 29, 2026 09:59
bc3d981 to
cd80e33
Compare
ssncferreira
force-pushed
the
ssncf/refactor-user-spend-limit
branch
from
July 29, 2026 10:05
cd80e33 to
9c53517
Compare
ssncferreira
marked this pull request as ready for review
July 29, 2026 10:07
johnstcn
approved these changes
Jul 29, 2026
Member
|
Hm... wasn't it API breaking change? |
Contributor
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Makes the user AI cost control endpoints consistent.
Changes
spend_limit_microsandlimit_sourcefields onGET /users/{user}/ai/spendwith a nestedeffective_budget, reusing the type behindgroup_budget. The flat pair made it possible to encode a limit without a source.AIGroupBudgettoAIBudgetLimit, since it also carriesuser_overridelimits and is no longer group-specific. The type name is not part of the wire format./users/{user}/ai/budgetto/users/{user}/ai/budget/override. The endpoint only ever managed the per-user override, which the type, the handlers, and the operation IDs all already said; the path was the only place that didn't.Note
Initially generated by Claude Opus 4.7, modified and reviewed by @ssncferreira