{{ message }}
fix: allow "me" shortcut in swagger user parameter validation#24692
Open
fix: allow "me" shortcut in swagger user parameter validation#24692
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #24473
The two quiet-hours endpoints in
enterprise/coderd/users.gohadformat(uuid)on their@Param userswagger annotations. Swagger UI validates this client-side, rejecting "me" as not a valid UUID before any request is sent.All other
{user}endpoints use plainstringwithoutformat(uuid). This removes the format constraint and updates the description to"User ID, name, or me"to match convention.Changes:
enterprise/coderd/users.go: removedformat(uuid)from both@Param userannotationscoderd/apidoc/docs.go,coderd/apidoc/swagger.json,docs/reference/api/enterprise.md: regenerated viamake genReview notes