{{ message }}
fix(site): handle invalid URLs in getAppHref to prevent UI crash#24691
Open
fix(site): handle invalid URLs in getAppHref to prevent UI crash#24691
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #24417
When a template specifies an invalid URL (e.g. a bare string like
my-appwith no scheme) on acoder_appresource withexternal = true, the call tonew URL(app.url)ingetAppHref()throws aTypeError, crashing the entire frontend UI.Wraps the
new URL()call in a try-catch and falls back to returning the raw URL when parsing fails. This ensures a single misconfiguredcoder_appnever brings down the whole dashboard.Changes:
site/src/modules/apps/apps.ts: try-catch aroundnew URL(app.url)with raw-URL fallbacksite/src/modules/apps/apps.test.ts: 3 new test cases (bare string, empty string, protocol-relative URL)Review notes