{{ message }}
fix: bedrock anthropic system prompt must be string#24685
Open
ibetitsmike wants to merge 3 commits intomainfrom
Open
fix: bedrock anthropic system prompt must be string#24685ibetitsmike wants to merge 3 commits intomainfrom
ibetitsmike wants to merge 3 commits intomainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Problem
Anthropic chat calls that go through the Bedrock provider were failing with 400 validationException on affected Bedrock paths. Captured wire shape on the way out:
Bedrock's Anthropic Messages schema expects
systemas a plain string.Fix
The actual fix lives in the fantasy fork: coder/fantasy#28 (branch
mike/bedrock-system-string, targetingcoder_2_33). This PR:charm.land/fantasyreplace pin to the commit that contains the fix.TestModelFromConfig_Bedrock/CapturesSystemFieldShapeto assertsystemis a JSON string equal to"you are helpful".The diagnostic test landed in a separate commit first so the failing shape is visible in history without depending on the fantasy bump.
Verification
All subtests pass, including
CapturesSystemFieldShapewhich logs:Order of merge
coder/fantasy#28 needs to merge into
coder_2_33first. Once that merges, this PR will be rebased to pin to the merge commit oncoder_2_33rather than the PR branch tip.Out of scope
No changes to
chatprompt,chatloop,aibridge, or any other non-Bedrock path.