chore: use coder/hc-install fork to fix expired PGP key verification by ethanndickson · Pull Request #24516 · coder/coder · GitHub
Skip to content

chore: use coder/hc-install fork to fix expired PGP key verification#24516

Merged
ethanndickson merged 1 commit intomainfrom
terraform-install-f40q
Apr 20, 2026
Merged

chore: use coder/hc-install fork to fix expired PGP key verification#24516
ethanndickson merged 1 commit intomainfrom
terraform-install-f40q

Conversation

@ethanndickson
Copy link
Copy Markdown
Member

@ethanndickson ethanndickson commented Apr 20, 2026

hc-install's bundled HashiCorp release-signing pubkey contains both the original armored block and a refreshed one, but openpgp.ReadArmoredKeyRing only decodes the first, so the verifier sees the expired key and terraform installs (and TestInstall) fail with openpgp: key expired.

Point github.com/hashicorp/hc-install at our fork, which parses every armored block and merges entities by fingerprint so the refreshed self-signature wins. We can drop the go mod replace once hashicorp/hc-install#371 (or an equivalent upstream fix) ships.

Relates to coder/internal#1476

hc-install's bundled HashiCorp release-signing pubkey contains both the original armored block and a refreshed one, but `openpgp.ReadArmoredKeyRing` only decodes the first, so the verifier sees the expired key and terraform installs (and `TestInstall`) fail with `openpgp: key expired`.

Point `github.com/hashicorp/hc-install` at our fork, which parses every armored block and merges entities by fingerprint so the refreshed self-signature wins. Drop the replace once hashicorp/hc-install#371 (or an equivalent upstream fix) ships.

Relates to coder/internal#1476
@ethanndickson ethanndickson marked this pull request as ready for review April 20, 2026 02:45
@ethanndickson
Copy link
Copy Markdown
Member Author

@ethanndickson ethanndickson merged commit 7e89534 into main Apr 20, 2026
37 checks passed
@ethanndickson ethanndickson deleted the terraform-install-f40q branch April 20, 2026 03:26
@github-actions github-actions Bot locked and limited conversation to collaborators Apr 20, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants