fix: apply --app-name to web page titles - #7794
Conversation
ffbdec0 to
cd15862
Compare
There was a problem hiding this comment.
Sorry for the delay, I was out of the office for a bit.
Thank you for reviving this!
Your reasoning makes sense to me, let's keep it as a separate patch.
I was thinking about how we add code-server: $version to the about dialog in integration.diff so we might need to modify that to show the configured app name instead, but really, if anything, I think this is an indication we should break that out of integration.diff rather than continue stuffing things into it.
4ca8d2b to
e898621
Compare
|
Ah the build fails because we also have to add |
|
I think this is what you mean by adding |
Unfortunately currently the unit test job does not build VS Code so it ends up with a 500 in CI. Might change that in the future but for now move it to an e2e test.
3 participants
An exact copy of the PR in #7725 by @jonathandunne, but rebased against latest. Fixes #7688 Original PR description below:
Summary
--app-nameto VS Code web bootstrap product configurationnameShort/nameLongso${appName}in tab titles uses the configured app nameTesting
npm install(partially completed but failed inlib/vscodeon missinggssapi/gssapi.hforkerberosunder Node 24)npm run test:unit -- --runInBand --runTestsByPath test/unit/node/routes/vscode.test.ts test/unit/node/routes/login.test.tssrc/node/http.ts(auth.cookie-max-agemissing onDefaultedArgs) before these route tests executed