{{ message }}
Fix install.sh refusing to download macos-arm64 standalone.#6968
Merged
Conversation
Member
Contributor
Author
yiliang114
pushed a commit
to yiliang114/code-server
that referenced
this pull request
Jan 23, 2025
* Fix install.sh refusing to download macos-arm64 standalone. * Update tests for macos-arm64 and amd64.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes part of #6659 (comment)
Ever since v4.89.0-rc.1, there's only macos-arm64 but no more amd64. This fixes the script to align with the actual release artifacts.
In the long run, if we ever add back macos-amd64, the check can be removed entirely.